Skip to content

fix(release): allow maintained documentation build helper - #269

Merged
killswitch-GUI merged 1 commit into
mainfrom
codex/preview-docs-readiness
Oct 7, 2026
Merged

killswitch-GUI merged 1 commit into
mainfrom
codex/preview-docs-readiness

Conversation

@killswitch-GUI

@killswitch-GUI killswitch-GUI commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

The first preview attempt after #265 (v0.11.7-preview.3, run 37684692146) stopped at release readiness because the maintained documentation container build helper was missing from the Python source allowlist. No draft or partial release was published, and that failed tag remains unchanged.

Allow exactly deploy/documentation/build-config.py, which selects portable documentation URLs and normalizes build timestamps. The retired root package and every other unexpected tracked Python source remain rejected; no directory-wide exception or completion check is added or skipped. After this repair passes review and both required gates, release from a new unused annotated preview tag.

Validation: the actual shell guard passes maintained SDK/helper files and rejects unexpected root Python, another Python file in the documentation directory, and root pyproject.toml in isolated Git fixtures. All 18 existing release-contract tests, shell syntax and diff checks pass. Change-selected local PR validation is running; its result and current-head hosted gates will be recorded before merge. SDK/runtime/UI sources are unchanged, and #265's coordinated operator Mac follow-up remains pending as recorded in 6043952713.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T21:01:38.781818Z ee49bd0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head ee49bd07 for the exact-path documentation build-helper allowlist repair. The actual shell guard passes maintained helper/SDK paths and rejects unexpected Python in both the root and the same documentation directory, plus root pyproject.toml. All 18 existing release-contract tests pass. Release readiness and all mandatory PR/full checks remain required; failed tag v0.11.7-preview.3 is preserved and no partial release was published.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: ee49bd0768

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

Local validation receipt for ee49bd076849ed671052ce4f9f8924fd574c3a65: all 18 release-contract tests and the four actual-guard positive/negative Git fixtures passed; workflow contracts/actionlint, formatting, crate structure, locked metadata and workspace denied-warning Clippy passed. The change-selected local PR gate then stopped on the unchanged private-home fixture: this managed host owns / as UID 65534, and the production ancestry guard correctly rejects it (explicit home ... private directory is unsafe: /). This is not an aggregate local pass. Current-head hosted Rust validation and complete Linux/AppArmor pre-merge acceptance remain mandatory; no ancestry or security guard is relaxed. Fresh automated review 6046776820 completed without findings; there are no review threads.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 7, 2026 — with ChatGPT Codex Connector

Copy link
Copy Markdown
Collaborator Author

Current-head PR run 37686202785 completed successfully on ee49bd076849ed671052ce4f9f8924fd574c3a65. Fresh review 6046776820 is clean, all review threads were rechecked (none), and the PR is non-draft and conflict-free. ci:full was requested after those checks. The unchanged private-home fixture also passed with the current prebuilt binary in the pinned PostgreSQL 17.9 container, UID 1000, read-only filesystem and no network; this focused result does not turn the environmental local-gate failure into an aggregate pass. Await every required full job and the current-head pre-merge gate before merge.

@killswitch-GUI
killswitch-GUI merged commit aee5621 into main Oct 7, 2026
28 of 37 checks passed

Copy link
Copy Markdown
Collaborator Author

Merged normally at aee562151d074ae8f503ad857ce3913411180688 after current-head PR validation 37686202785, fresh clean review 6046776820, no review threads, and full acceptance 37686874046 all passed. The merge tree exactly equals tested head ee49bd076849ed671052ce4f9f8924fd574c3a65. Complete Linux Rust/AppArmor, all native/platform/security jobs, Windows's 17 approval cases, macOS's 16 approval cases and 294 browser cases passed (14 expected platform skips; no browser retry in this final run).

The new unused annotated tag v0.11.7-preview.4 now points to this reviewed main commit; failed .3 remains unchanged. Exact-tag release candidates 37693493469 and documentation candidates 37693493467 are running. Draft publication remains gated on successful candidates and all 38 independent byte comparisons, 18 checksums and six VSIX identities; container publication/anonymous digest verification follow. The operator Mac account/UI check remains pending and coordinated in #265 comment 6043952713.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run cost-bounded full pre-merge acceptance on the current PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant