Skip to content

fix(release): generate SDK bindings and fix acceptance races - #271

Merged
killswitch-GUI merged 3 commits into
mainfrom
codex/vsix-codegen-readiness
Oct 8, 2026
Merged

killswitch-GUI merged 3 commits into
mainfrom
codex/vsix-codegen-readiness

Conversation

@killswitch-GUI

@killswitch-GUI killswitch-GUI commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

A fresh v0.11.7-preview.4 checkout compiled the SDK before generating its ignored TypeScript Protobuf bindings, so all six VSIX targets failed with TS2307. Install the pinned Go 1.25/Python 3.10.18 tools and run the canonical SDK installer/generator before compilation; tracked SDK drift fails the job. Retain extension checks, exact-target native keyring integrity checks and packaging gates, and cache all three lockfiles.

Repair two native acceptance races. Enabled background scheduled tasks shared the fixture's pending provider response and could consume the explicit bridge run's tool call; reserve that one-shot response for the latest explicit bridge input, including scalar and multipart content. The workflow test also audited contrast immediately after changing themes, sometimes measuring intermediate button/background colors; wait for the actual CSS transitions to finish before both theme audits. Background execution, normal animations, all approval/idempotency assertions and every accessibility rule remain intact. Runtime policy and runtime/UI/SDK sources are unchanged.

Validation:

  • A genuinely clean checkout passed canonical generation without SDK drift, SDK compilation, complete extension checks/build and all six packages. Each VSIX has the correct manifest platform and one matching native keyring binding; extension version remains 0.1.14. The official SDK gate passed, and input digest remains e05323d40846e298f37979d0881346fd6c34930d84d2d85ddfc7e69acdd5e1ef.
  • The actual HTTP fixture handler reproduces background response theft before repair; scalar/multipart, SSE/JSON, latest-input routing and one-shot checks pass after repair. In full run 37705174494, macOS passed all 16 applicable approval cases, 294 browser tests without retries (14 expected skips), plugins and native checks. Windows passed the workflow's approval/idempotency assertions and 16 other cases, then failed only the final theme-transition audit. That full run remains failed evidence.
  • The rendered production CSS demonstrates 50 active transitions and an intermediate primary color before settling to the canonical light palette. Full Axe audits pass for settled dark and light themes, including a check using the actual new helper. The official Desktop gate passed after the final edit, including its renderer budget; commit hooks pass.
  • Both current-head hosted gates and fresh review remain mandatory before normal merge. The managed-host local aggregate PR limitation (root owned as UID 65534) remains recorded and is not counted as an aggregate pass.

Failed tags .3 and .4 remain unchanged and unpublished. After complete acceptance and normal merge, use a new unused annotated preview tag, verify all 38 assets against exact-tag Actions candidates, and complete container/VSIX publication and anonymous digest verification. The original operator Mac account/UI check remains coordinated and pending in #265 comment 6043952713.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T00:54:13.631197Z 5220909 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review head bee226c2d30aba1a759af53986f8adf82296c94c. This fixes all six clean-checkout VSIX failures in tag v0.11.7-preview.4 by invoking the existing pinned canonical SDK generator before compilation; no generated files, runtime/UI/SDK sources or signing/security checks change. A fresh detached worktree started without ignored bindings and passed generation with zero manifest drift, SDK compile, full extension checks/build and all six target packages, each with its correct manifest/native keyring binding. Official cargo xtask check sdk --base origin/main also passed, including languages/examples/vet/package checks. Workflow/actionlint/hooks pass. Both current-head hosted PR/full gates remain mandatory before normal merge and a new unused tag; failed .4 stays unchanged and unpublished.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: bee226c2d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

Current-head readiness receipt for bee226c2d30aba1a759af53986f8adf82296c94c: PR run 37697250398 completed successfully, including hosted Rust tests/Clippy, Desktop validation, complete SDK and worker/Electron/extension checks, and the aggregate PR gate. Fresh manual Codex review 6048306222 is clean; no review threads remain. The official local SDK and Desktop gates also completed successfully; the local aggregate PR failure on the managed host's root UID remains explicitly recorded, not counted as a pass. Requesting ci:full on this reviewed, conflict-free, non-draft head; the branch and PR body stay unchanged during acceptance. Failed tags .3 and .4 remain unchanged and unpublished. The actual operator Mac account/UI follow-up remains pending and coordinated in #265 comment 6043952713.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 7, 2026 — with ChatGPT Codex Connector
@github-actions github-actions Bot removed the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 7, 2026
@killswitch-GUI killswitch-GUI changed the title fix(release): generate SDK bindings before VSIX builds fix(release): generate VSIX SDK and isolate acceptance responses Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review current head 69d5e29c15ab28e2da2c6825e855b1e9b11e483c. Since the clean bee226c review, only the isolated native acceptance provider fixture changes. Enabled scheduled task requests could consume its global pending response; the exact actual HTTP handler reproduces theft before the repair. Route the armed one-shot response only to the latest explicit bridge input, supporting scalar/multipart and SSE/JSON; all approval/idempotency assertions, schedule execution and runtime policy remain unchanged. Controlled checks and the official Desktop gate pass. Full attempt 37698164979 has completed and remains failed; fresh current-head PR/full results are mandatory before normal merge and a new unused tag.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 69d5e29c15

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

Current-head readiness receipt for 69d5e29c15ab28e2da2c6825e855b1e9b11e483c: PR validation 37704256100 completed successfully, including the aggregate PR gate, Rust tests/Clippy, SDK languages and worker/Electron/sidebar/package acceptance, and Desktop validation. Fresh manual review 6049163985 is clean, with no review threads; the head is mergeable and non-draft. The isolated provider race was reproduced with the actual HTTP handler and repaired without changing runtime policy or approval assertions; the official local Desktop gate also passed. Requesting ci:full again on this reviewed current head. Previous failed/cancelled runs remain diagnostic evidence. Keep source/body/other labels unchanged during full acceptance. No preview tag or partial release was published; the original operator Mac account/UI follow-up remains coordinated and pending.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 7, 2026 — with ChatGPT Codex Connector
@github-actions github-actions Bot removed the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 8, 2026
@killswitch-GUI killswitch-GUI changed the title fix(release): generate VSIX SDK and isolate acceptance responses fix(release): generate SDK bindings and fix acceptance races Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review final head 5220909e2eed18e837ebdd84e04f312d49474c35. Since clean review 69d5e29, only the workflow acceptance test changes: await actual CSS transition completion after each theme switch before the unchanged full Axe audit. The previous full run completed with macOS approval/browser/native acceptance passing; Windows reached the final audit and measured intermediate colors during the 120ms theme transition. Rendered production CSS proof confirms the transition and full settled light/dark audits pass, including the actual new helper. Official Desktop gate and hooks pass. Animations, contrast checks, runtime policy and approval assertions are unchanged. Fresh current-head PR/full results remain required; failed tags and failed runs are not acceptance or publication evidence.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 5220909e2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator Author

Current-head readiness receipt for 5220909e2eed18e837ebdd84e04f312d49474c35: PR run 37710050568 completed successfully, including Rust tests/lint, Desktop, SDK and worker/Electron/sidebar/package validation, and the aggregate PR gate. Fresh review 6049908702 is clean; no review threads remain, and the head is conflict-free and non-draft. Rendered checks using the actual theme helper pass the complete dark/light Axe audits after real CSS transitions; the official local Desktop gate and hooks also passed. Requesting ci:full on this fixed reviewed head. Previous failed runs remain diagnostic evidence; source/body/other labels stay unchanged during acceptance. Failed tags .3 and .4 remain unchanged/unpublished. The original operator Mac account/UI check remains coordinated and pending in #265 comment 6043952713.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 8, 2026 — with ChatGPT Codex Connector

Copy link
Copy Markdown
Collaborator Author

Full acceptance on 5220909e2eed18e837ebdd84e04f312d49474c35 completed with one Windows shell-list read timeout. All other acceptance and packaging jobs passed, including macOS: 294 browser tests with 14 expected skips and no retries; 8 plugin tests; 16 approval cases with one expected platform skip. Windows passed 16 approval cases, including workflow idempotency and both full theme accessibility audits; the real workspace-server case timed out on its five-second authenticated list_shell_sessions read before renderer connection. The failed attempt remains diagnostic evidence (artifact 11522898762, SHA-256 e30824130c80accf47ed55c43acbf042f67db21a48f4d884e24c170973f2c1be). No source defect has been confirmed. After the workflow completed, I requested one targeted rerun of the Windows job and dependent pre-merge gate on the unchanged head to test whether the read failure recurs. Merge and preview publication remain pending the required green result.

Copy link
Copy Markdown
Collaborator Author

Accepted current head 5220909e2eed18e837ebdd84e04f312d49474c35: PR run 37710050568 and full run 37711011644 attempt 2 both completed successfully, and both required current-head gates are green. The targeted Windows rerun passed all 17 approval cases (3.5m) and 8 plugin cases; the earlier five-second shell-list timeout remains recorded as a failed attempt. Retained macOS acceptance passed 294 browser cases without retries (14 expected skips), 8 plugins and 16 applicable approval cases (one expected platform skip). All native/security/service/package jobs passed. Fresh clean review 6049908702 covers this exact commit; review threads are empty. REST reports nondraft, conflict-free and mergeable with unchanged base aee562151d074ae8f503ad857ce3913411180688. Proceeding with normal expected-head squash merge and a new unused preview tag, then independent asset and public-container verification. The coordinated operator Mac account/UI check remains pending, as documented in #265.

@killswitch-GUI
killswitch-GUI merged commit 538ddef into main Oct 8, 2026
64 of 72 checks passed

Copy link
Copy Markdown
Collaborator Author

Merge verification correction: GitHub PR metadata reported the older base, but actual merge 538ddefa2d7d035a2f18aaba38555cfb32a1ed19 has parent 312625090ad5dc6da98135c77de91db196d90067. Main advanced through #270, #272, #273, #275 and #274 during acceptance. Each intervening PR has successful current-head PR and pre-merge gates; their changes leave the SDK generation inputs, release workflow and both repaired fixture files unchanged. The three-file merge diff is exactly the accepted repair, but the complete merged tree is different from the original PR head and is not claimed equivalent. The Windows targeted rerun checked a merge snapshot including #270/#272; later MCP/research changes have their own full acceptance. The new preview will identify the actual merged commit and must pass its own exact-tag complete release-readiness, signing, native smoke and packaging gates before any publication.

Copy link
Copy Markdown
Collaborator Author

Exact-tag .5 readiness, both documentation architectures, all six VSIX targets, both Control Plane targets, Windows Desktop Authenticode/install/launch/uninstall smoke checks and macOS Desktop ad-hoc signing/bundle verification passed. macOS arm64 CLI passed native acceptance, release build, packaging and archive upload by 03:42 UTC, then its optional registry cache post-action stalled for approximately 50 minutes. GitHub cancelled that job after the configured 60-minute budget and cleanup window; release gate failed and final signing/draft creation were skipped. The entire attempt is recorded as cancelled, not accepted; no draft or partial publication occurred. After confirming workflow completion, I requested one targeted rerun of the macOS arm64 CLI job and its dependent release/signing jobs on the unchanged tag and source. Fourteen approved immutable candidate archives are independently retained with verified GitHub archive digests. Publication remains conditional on successful complete release recovery and all 38 independent candidate/Release byte comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run cost-bounded full pre-merge acceptance on the current PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant