Repository navigation
feat(desktop): add opt-in Windows computer control - #300
Merged
Merged
Conversation
killswitch-GUI
marked this pull request as ready for review
October 19, 2026 07:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
killswitch-GUI
changed the base branch from
codex/windows-browser-action-stability
to
main
October 19, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in Windows computer use with global/workspace settings and the bundled
colossus/computer-useskill. Agents select existing ordinary-user windows, inspect accessibility or target-window PNGs, and apply mouse/keyboard input against fresh observations. Closing automation leaves the user's application running.Expose exactly 13
computer.*tools: windows, open, status, snapshot, screenshot, focus, move, click, drag, scroll, type, press, and close. Authenticated Desktop/connector grants and attached-plus tool search now discover them outside Minimal mode. Native availability, configuration, policy/approval, ownership and per-run limits remain required; authenticated sidecar acceptance covers discovery without desktop effects.The native card provides separate state-aware Pause, Resume and Stop buttons. A delayed Pause after human takeover cannot resume control. Physical Escape stops native control; Ctrl+Alt+P pauses only; injected events cannot activate these shortcuts. Stop revokes native input and fences same-owner reopening. The runtime cancels the owning run upon a positive native UserStopped error or validated released status; this does not promise instantaneous interruption of an in-flight provider request. Pause, stale observations and generic denial remain recoverable; possibly applied input remains OutcomeUnknown and cannot be replayed automatically.
Fix the live 128-window read failure by narrowing valid optional window/snapshot counts to resolved workspace/native ceilings before policy and dispatch. Invalid types, zero and protocol overflow still fail. Consumed, mismatched or expired observations now produce trusted categorical stale previews, alongside fixed denial/count-limit recovery guidance, without leaking arbitrary native errors.
Computer screenshots use the inline image pipeline with distinct labels. Enlarged PNGs hide the native browser surface; Escape or the close button restores the same retained page. The skill documents observation replacement, freshness, new-run IDs and recovery. Codex compatibility advances to protocol 0.163.0 with GPT-6.1 Sol coverage and bounded opt-in redacted provider diagnostics.
Validation:
0299cac53c5dd19c0322cda04eeb3e6034761060. Hosted PR checks: 9/9 passed. Full platform acceptance remains pending. The local PR command passed its Rust checks, then stopped at the documented Windows limitation that SDK generation requires the repository's POSIX scripts. Exact-head hosted SDK validation passed. The required localcargo xtask check rustcompleted successfully on this head.15a6ee7fordinary-user native acceptance passed, including occlusion-safe capture, accessibility, Unicode, balanced drag, owned dialogs, contention, revocation and acknowledged cleanup. A real GPT-6.1 Sol development run completed 30 actions in 163 seconds with no failed native tools: 17 computer, 10 browser and three orchestration actions. It verified 128-window/1024-node requests, fixture text/Clicked, inline/enlarged PNGs, styled Google/GitHub, terminal/minimize restoration and natural-completion Last view. Long-idle retained pixels and expired human-session recovery also passed.0299changes only the Windows Desktop CI budget 75→90 minutes and its matching contract after a cold-cache timeout; CEF's 45-minute bound, per-test limits and acceptance coverage are unchanged. The Intel macOS CLI release job also has a bounded 90-minute cold-build budget; other CLI targets retain 60 minutes.Exact signed-installed browser acceptance remains a separate publication gate; development/source evidence does not replace it.