Repository navigation
fix(provider): project Anthropic-compatible tool schemas - #301
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthropic rejects an entire Messages request when an offered tool has a top-level
oneOf,anyOf, orallOfinput-schema constraint. The native adapter forwarded canonical schemas unchanged, so built-ins such asshell.run,user.ask, andworkflow.schedule.createcould trigger HTTP 400 before any tool executed.Project only those three unsupported root keywords out of the Anthropic wire schema. Preserve nested schemas and references, canonical local validation and continuation bindings, and existing OpenAI behavior. JSON and SSE gateway tests now offer the complete built-in catalog; additional regressions cover nested schemas and canonical validation.
Desktop plugin acceptance also allows the native inventory refresh's 45-second budget when checking the enabled state after reactivation. Native activation and the subsequent inventory refresh are separate requests; the former five-second assertion could expire between them. The enabled-state assertion, native integration path, scenario timeout, and retry policy remain intact.
Validation:
No paid endpoint calls were made for this fix. The reported offline deployment needs an updated binary before it can be retested.