Skip to content

fix(provider): project Anthropic-compatible tool schemas - #301

Merged
killswitch-GUI merged 2 commits into
mainfrom
codex/fix-anthropic-tool-schemas
Oct 19, 2026
Merged

killswitch-GUI merged 2 commits into
mainfrom
codex/fix-anthropic-tool-schemas

Conversation

@killswitch-GUI

@killswitch-GUI killswitch-GUI commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Anthropic rejects an entire Messages request when an offered tool has a top-level oneOf, anyOf, or allOf input-schema constraint. The native adapter forwarded canonical schemas unchanged, so built-ins such as shell.run, user.ask, and workflow.schedule.create could trigger HTTP 400 before any tool executed.

Project only those three unsupported root keywords out of the Anthropic wire schema. Preserve nested schemas and references, canonical local validation and continuation bindings, and existing OpenAI behavior. JSON and SSE gateway tests now offer the complete built-in catalog; additional regressions cover nested schemas and canonical validation.

Desktop plugin acceptance also allows the native inventory refresh's 45-second budget when checking the enabled state after reactivation. Native activation and the subsequent inventory refresh are separate requests; the former five-second assertion could expire between them. The enabled-state assertion, native integration path, scenario timeout, and retry policy remain intact.

Validation:

  • Four intended regression failures reproduced before the provider fix; complete provider library suite then passed all 109 tests, including OpenAI regressions.
  • Provider all-target Clippy with warnings denied, formatting, crate structure, independent review, and strict documentation build passed.
  • Desktop checks passed: 542 unit tests; security contracts (65 passed, one platform-specific skip); type and formatting checks; renderer build and bundle-size check; three operation-synchronization tests.
  • Full local Rust and Desktop gates were attempted but could not complete within the machine's remaining disk space. Local PR validation also encountered an unchanged Windows GNU-tar drive-letter fixture failure. Hosted exact-head PR and full acceptance gates are required before merging.

No paid endpoint calls were made for this fix. The reported offline deployment needs an updated binary before it can be retested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T16:07:12.511784Z d1a3e1d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 19, 2026
@github-actions github-actions Bot removed the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 19, 2026
@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 19, 2026
@killswitch-GUI
killswitch-GUI merged commit c03a0db into main Oct 19, 2026
51 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run cost-bounded full pre-merge acceptance on the current PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant