Repository navigation
ci: refresh Windows signing credentials after cold builds - #302
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
killswitch-GUI
added
the
ci:full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows Desktop signing failed with AADSTS700024 after a long unsigned build reused an expired GitHub federation assertion. Refresh Azure OIDC login immediately before browser signing, nested-binary signing, and Tauri installer packaging.
The release contract now verifies those authentication boundaries, the pinned action and credential references, and the matching preview condition. Existing signing, sealing, publisher/timestamp verification and installer smoke checks remain in place.
Validation: focused signing contracts 2/2; complete Desktop contract file 38/38; cargo xtask check workflows passed. The required local cargo xtask pr --base origin/main completed its Rust checks, then exited at the documented Windows limitation that SDK generation requires the repository's POSIX scripts. Current-head hosted SDK/Desktop and full acceptance remain required. Actual Azure signing will be exercised by the next annotated preview tag.
Failure evidence: https://github.com/obscuritylabs/Colossus/actions/runs/39275997248/job/118151657477
Need help on this PR? Tag
@codesmith-botwith what you need.