Skip to content

fix(windows): repair browser startup and computer focus guidance - #303

Merged
killswitch-GUI merged 3 commits into
mainfrom
codex/computer-foreground-guidance
Oct 20, 2026
Merged

killswitch-GUI merged 3 commits into
mainfrom
codex/computer-foreground-guidance

Conversation

@killswitch-GUI

@killswitch-GUI killswitch-GUI commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Windows browser startup could crash before opening a tab when a configured application home produced a temporary engine profile beyond Chromium's Windows path limit. Allocate that temporary state in a short, private directory under the token-derived Windows user profile, retaining the instance binding and existing native cleanup ownership. Disable Chrome's file-logging destination outside explicit startup diagnostics.

Disconnecting the browser viewer repeatedly reissued native hide/focus-loss calls during subsequent agent operations. Apply terminal viewer revocation once while keeping its admission fence permanently closed. Regression tests cover duplicate notifications, repeated event-loop passes, denied viewer commands and closing acknowledgements.

Computer observations can read a background window without activating it. When the selected window is in the background, the bundled skill, tool descriptions and stale-observation guidance now direct the agent to focus it and obtain a fresh observation before input. Existing foreground, identity, observation and permission guards are unchanged. The Windows CI runner keeps raw startup fixtures short and applies long managed ancestry only to the runtime factory regression.

Validation:

  • Clean 02076cfd source Release-host acceptance passed all twelve browser checks, including all four keyboard-navigation cases, long managed ancestry, a short private engine profile, no file logs, real input, frames, transfers, tabs and acknowledged native cleanup (17.47 seconds).

  • Clean 02076cfd, ordinary-user native Computer Use acceptance passed, including two fresh background-click rejections followed by explicit focus and successful input, modal and contention guards, cancellation, balanced drag and cleanup (15.84 seconds).

  • The new terminal-revocation regression failed against the prior implementation (14 native revocations instead of one). All seven linked presentation tests and strict Release Clippy passed after the fix.

  • Four Windows token-profile tests, the Runtime path-budget test, focused computer guidance/packaging tests, and strict feature Clippy passed. The existing Windows native CI lane now exercises the Release host.

  • cargo xtask check rust passed in full on the clean commit, including workspace tests, documentation tests and strict fuzz Clippy.

  • cargo xtask pr --base origin/main passed workflow contracts and its complete Rust checks, then stopped at the explicit Windows limitation: SDK generation requires the repository's POSIX generator scripts. SDK, Desktop, documentation and dependency checks were not reached locally; required hosted checks remain mandatory.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T22:35:41.216551Z d714d59 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 19, 2026
@github-actions github-actions Bot removed the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 20, 2026
@killswitch-GUI killswitch-GUI added the ci:full Run cost-bounded full pre-merge acceptance on the current PR head label Oct 20, 2026
@killswitch-GUI
killswitch-GUI merged commit b675e04 into main Oct 20, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run cost-bounded full pre-merge acceptance on the current PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant