Repository navigation
fix(windows): repair browser startup and computer focus guidance - #303
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows browser startup could crash before opening a tab when a configured application home produced a temporary engine profile beyond Chromium's Windows path limit. Allocate that temporary state in a short, private directory under the token-derived Windows user profile, retaining the instance binding and existing native cleanup ownership. Disable Chrome's file-logging destination outside explicit startup diagnostics.
Disconnecting the browser viewer repeatedly reissued native hide/focus-loss calls during subsequent agent operations. Apply terminal viewer revocation once while keeping its admission fence permanently closed. Regression tests cover duplicate notifications, repeated event-loop passes, denied viewer commands and closing acknowledgements.
Computer observations can read a background window without activating it. When the selected window is in the background, the bundled skill, tool descriptions and stale-observation guidance now direct the agent to focus it and obtain a fresh observation before input. Existing foreground, identity, observation and permission guards are unchanged. The Windows CI runner keeps raw startup fixtures short and applies long managed ancestry only to the runtime factory regression.
Validation:
Clean
02076cfdsource Release-host acceptance passed all twelve browser checks, including all four keyboard-navigation cases, long managed ancestry, a short private engine profile, no file logs, real input, frames, transfers, tabs and acknowledged native cleanup (17.47 seconds).Clean
02076cfd, ordinary-user native Computer Use acceptance passed, including two fresh background-click rejections followed by explicit focus and successful input, modal and contention guards, cancellation, balanced drag and cleanup (15.84 seconds).The new terminal-revocation regression failed against the prior implementation (14 native revocations instead of one). All seven linked presentation tests and strict Release Clippy passed after the fix.
Four Windows token-profile tests, the Runtime path-budget test, focused computer guidance/packaging tests, and strict feature Clippy passed. The existing Windows native CI lane now exercises the Release host.
cargo xtask check rustpassed in full on the clean commit, including workspace tests, documentation tests and strict fuzz Clippy.cargo xtask pr --base origin/mainpassed workflow contracts and its complete Rust checks, then stopped at the explicit Windows limitation: SDK generation requires the repository's POSIX generator scripts. SDK, Desktop, documentation and dependency checks were not reached locally; required hosted checks remain mandatory.Need help on this PR? Tag
@codesmith-botwith what you need.