Support for Django 2.0#49
Open
jsmitka wants to merge 3 commits into
Open
Conversation
… Updated tests and closure model with on_delete=models.CASCADE.
Collaborator
|
I've managed to miss noticing this completely. @jsmitka Sorry for taking so long to get back to you on this, I appreciate the effort required to make a contribution. I'll try and review this soon. |
|
Hi @mikebryant. Do you have a chance to review this PR? Thanks in advance. |
|
@mikebryant hello, any chances accepting this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 2.0 made the
on_deleteargument ofForeignKeys required. I have added this argument (set tomodels.CASCADE, since it think it is the only logical option) to both code and tests. I've also updated.travis.ymlto include the Django 2.0 environment on Python 3.6 and PyPy3.5v5.10.1.