Skip to content

Fix: __unicode__ must return unicode#53

Open
dpetukhov wants to merge 1 commit into
ocadotechnology:masterfrom
dpetukhov:master
Open

Fix: __unicode__ must return unicode#53
dpetukhov wants to merge 1 commit into
ocadotechnology:masterfrom
dpetukhov:master

Conversation

@dpetukhov

Copy link
Copy Markdown

Because if str(self.parent) returns something like \xd0\xbf\xd1\x80\xd0\xb8\xd0\xb2\xd0\xb5\xd1\x82 and you try to print(ModelClosure), you will get UnicodeEncodeError

I see this error in Django Admin interface on delete confirmation page when I try to delete User which has linked Comments which have CommentClosure instances saved in database. And django admin trying to show string representation of all objects and fails.

Reference:

Because if `str(self.parent)` actually returns something like `\xd0\xbf\xd1\x80\xd0\xb8\xd0\xb2\xd0\xb5\xd1\x82` and you try to `print(ModelClosure)`, you will see UnicodeEncodeError
@dpetukhov

Copy link
Copy Markdown
Author

Probably I need to add some tests to actually prove the issue and fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant