Open
Conversation
c-cube
force-pushed
the
simon/no-mutex-in-batch-2025-12-01
branch
from
72b0662 to
db2b2b8
Compare
follow more closely the official OTEL recommendations, and also try to reduce global state. - use a class type for `Exporter.t` (instead of 1st class module `backend`) - have tracer, logger, metrics_emitter as explicit objects - keep a `Main_exporter` to make migration easier, but discouraged - add stdout_exporter and debug_exporter to opentelemetry.client
now we modify batches on the fly when we send signals; but there still is a thread pool to send signals via HTTP.
now that fields are mutable, it's cheaper and easier
we have a new explicit `Storage.t` interface, that can be used to get a `Context.t` (a hmap) and to locally swap it; then we have multiple implementations of the Storage; and then we have a singleton atomic containing the "main" storage.
a bit like a buffered writer for any data
c-cube
force-pushed
the
simon/no-mutex-in-batch-2025-12-01
branch
from
db2b2b8 to
f542750
Compare
this should result in lower overhead for single threaded situations such as lwt or eio.
c-cube
force-pushed
the
simon/no-mutex-in-batch-2025-12-01
branch
from
f542750 to
107e173
Compare
c-cube
force-pushed
the
main
branch
7 times, most recently
from
e939ad7 to
6a46859
Compare
c-cube
force-pushed
the
main
branch
2 times, most recently
from
3494f6c to
5065cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using a mutex is heavy for situations that are (mostly) single threaded, such as
Lwt or Eio backends. Using atomics should be good enough, and degrades to a simple
refunder OCaml 4.