Repository navigation
fix(e2e): preserve Bub version when installing ACP - #1823
Merged
Merged
Conversation
Teingi
marked this pull request as ready for review
October 1, 2026 11:34
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1822.
Rationale for this change
The harness installs Bub 0.4.2, but
bub install bub-acp-server==0.0.2initializes a plugin project with an unpinned Bub dependency and resolves it to 0.5.0. Its shell command path passescommand, while ACP 0.0.2 expectscmd, breaking E2E acceptance before terminal execution. The failing master run reports this version drift in its ACP handshake and replay evidence.What changes are included in this PR?
bub=={BUB_VERSION}together with the ACP plugin requirement so both PowerContext ON and OFF installations preserve the harness version.Are there any user-facing changes?
E2E agent installation remains on the configured Bub version instead of silently upgrading it. There are no public API, persisted-format, or runtime dependency declaration changes.
How was this change tested?
PATH="$PWD/.venv/bin:$PATH" TMPDIR=/data/codex-tmp uv run prek run -a— all hooks passed, including Ruff and the root type check..venv/bin/ruff check e2e/buband.venv/bin/ruff format --check e2e/bub— passed..venv/bin/ty check --project e2e/bub --python e2e/bub/.venv --python-version 3.12 e2e/bub/src integrations/bub/src— passed.TMPDIR=/data/codex-tmp e2e/bub/.venv/bin/python -m pytest e2e/bub/tests— 101 passed.e2e/bub/.venv/bin/python -m powercontext_e2e --help— passed.printf acp-pin-okthrough the terminal and receivedend_turn.The ACP subprocess probe ran outside the filesystem sandbox after both versions stalled inside it. This does not claim a complete Harbor, real-model, or SQLite/OceanBase acceptance rerun; those remain for CI.
AI usage statement
OpenAI Codex (GPT-6) was used to inspect CI logs and artifacts, implement the change, run validation, and prepare this Issue and PR.