Repository navigation
fix(dsh): diagnose native MCP tool catalog - #1876
Merged
Teingi merged 1 commit intoOct 8, 2026
Merged
Conversation
DongYao0
requested review from
PsiACE,
Teingi and
zhanghuidinah
as code owners
October 7, 2026 16:36
Collaborator
Contributor
Author
|
Thanks for the heads-up. That makes sense. Since #1784 is refactoring the DSH plugin to native MCP, I agree it is safer to move the MCP catalog diagnosis forward after that work lands, rather than merge a change against the current HTTP-plugin architecture. I’ll keep this PR open as a reference for now and refresh or rework it on top of #1784 once the refactor is available. Please let me know if you would prefer that I close this PR and submit a new focused follow-up instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Addresses the MCP catalog diagnosis portion of #1785.
Rationale for this change
The documented DSH plugin uses HTTP and exposes
pc_*tools, while native DSH MCP is optional./pc doctorcould verify HTTP/plugin health but could not distinguish an absent native PowerContext MCP catalog from a healthy HTTP setup.What changes are included in this PR?
tools.schemas(agent)catalog only when/pc doctorruns.mcp__powercontext__*tools.Are there any user-facing changes?
Yes.
/pc doctorincludeschecks.mcp_catalogwith explicit native MCP visibility status and recovery guidance. It does not change HTTP plugin health semantics or public HTTP APIs.How was this change tested?
pnpm test— 275 passed, 1 skipped.pnpm buildpnpm test:e2e— 9 passed.pnpm lint,pnpm test, andpnpm build— 875 public pages and links verified.The local Windows commit hook’s repository-wide
ty checkreports pre-existing POSIX-only Python attribute diagnostics in unrelated files; no Python source was changed. The DSH package build and all relevant tests above passed.AI usage statement
Implemented and verified with OpenAI Codex. AI assistance was used for source tracing, implementation, regression-test design, documentation, and validation; the resulting changes were reviewed locally.