Repository navigation
Conversation
frf12
requested review from
AlexStocks,
PsiACE,
Teingi and
frostming
as code owners
October 9, 2026 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #1882. All correction commits from this PR are included in the Atomic integration branch; review and validation continue in #1882.
Which issue or RFC does this PR close?
Follow-up to merged #1862 and RFC #1858, addressing P2 and P3 from its final review. The common fixes will also be synchronized into the Atomic integration PR #1882.
Rationale for this change
Desktop upgrade instructions still selected a historical contract that the native connection gate rejects. Topic text search also accepted positive lexical admission floors that overflow SQLite INTEGER binding, returning 500 even for an empty Scope.
What changes are included in this PR?
Are there any user-facing changes?
Desktop upgrades can explicitly choose the profile that matches the bundled contract. Historical evidence is retained and incompatible selections are explained. Impossible lexical admission floors now return empty lexical results instead of a server error; semantic results remain available in hybrid mode.
No API schema, generated code, dependency, persisted format, or shared authorization changes. The historical Experience/Skill authorization race is tracked separately in the P1 reply, which asks for a separate issue. The existing Topic read reauthorization and snapshot protection remain.
How was this change tested?
Current reviewed HEAD:
0ac9186b514356636553d11649a814a0638144cf, synchronized into Atomic #1882 atf9570ed28626935408a87bf57420549d2c80ddc5.The next actual Windows execution 37904671893 passed 28 UI tests, all native suites, and real Server/CLI stages, then failed installed smoke while selecting the current compatibility profile. Its XPath assumed the option was a direct select child; the production UI now groups profiles. The final correction changes only
select/optiontoselect//optionin the installed harness, retaining the exact qualified profile ID, existing WebDriver enabled check and every later acceptance assertion. No production or qualification changes.The coordinator independently repeated the external actual-rendered Connections XPath probe in each checkout: 1 passed, 0 failed, 0 skipped for Base and separately for Atomic. Exact current options remain enabled and selectable, and default selection remains empty. Both checkouts passed
make check(33 manifest tests each) and three-script Ruff/format/Windows-platform/Linux-platform Ty checks. These local jsdom and static checks do not establish installed Windows acceptance; CI for the current heads is pending. The failed older installed runs remain recorded. The final commit changes only one XPath slash; other source/test results below retain their original material.Historical reviewed HEAD:
763022e7b5c30fe0c505beaa193a2fdbbf59b82c. Both fixes and the test-only navigation synchronization are included in Atomic #1882 at5c77f0221d5b11b067263e3cbf4eb77515766342.The first Windows run 37903135663 retained 27 passed, 1 failed, 0 skipped in the old late-Memory-save UI case; subsequent native/installed acceptance was not reached. Before editing tests, real focus/key/input event instrumentation demonstrated the existing navigation RAF moving focus to the H1 during test typing. The fixture now waits for each successful page navigation's heading focus before typing, including the intermediate Overview transition. All existing late-save, confirmation and complete-text assertions remain; production UI and RAF behavior are unchanged. The diagnostic's 1 passed, 2 failed, 16 skipped is preserved separately from the Windows failure.
Coordinator independently repeated the complete final Base UI: 28 passed, 0 failed, 0 skipped. Complete Atomic UI after synchronization: 34 passed, 0 failed, 0 skipped. Both final materials passed
make check(each includes 33 integration-manifest tests), Desktop lint/build and whitespace checks. The Topic executions below used the unchanged Python correction material; the final fixture commit modifies only two UI test files. New-head CI is pending and the earlier failed run is retained.Coordinator independently executed on the reviewed material:
-k 'not live_oceanbase'). Python 3.12.7, actual SQLite 3.45.3 and sqlite-vec 0.1.9, deterministic local embeddings.pnpm test: 28 passed, 0 failed, 0 skipped, using bundled Node 24.19.0. The package's existing exact Node 24.14.1 engine warning remains.make check: passed, including lock consistency, pre-commit, type checks and 33 integration-manifest tests.pnpm run lintandpnpm run build: passed, including generated-contract checks and TypeScript.git diff --check: passed.Before implementation, the new Desktop cases failed for the reported behaviors, and the actual SQLite HTTP regression failed with INTEGER overflow. New Python regressions cover the signed-64-bit boundary, a much larger integer, ordinary lexical matches, short queries and retained hybrid vector results. OceanBase coverage uses a simulated connection; no native OceanBase execution is claimed. UI tests use jsdom with mocked native IPC; no installed Windows execution is claimed for these local checks. CI results belong to this PR's published HEAD and will be verified separately.
AI usage statement
GPT-6.1 Sol with ultra reasoning implemented the two independently scoped fixes. The coordinating Codex agent reviewed the changes and independently ran the affected regressions and repository checks.