Repository navigation
fix(desktop): isolate CI fixture qualification and fix grouped selection - #1907
Merged
Merged
Conversation
Refs #1903. Qualify disposable native and installed fixtures explicitly, preserve fail-closed production profiles, and select compatibility options within optgroups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1903.
Rationale for this change
Contract changes leave synthetic fixtures without matching historical qualification. Installed acceptance also cannot locate compatibility options inside
<optgroup>elements.What changes are included in this PR?
Provide explicit fixture qualification for native tests and opt-in
ci-fixturesinstaller builds, recording and checking the contract, commit, and wheel identities while preserving historical evidence and fail-closed checks. Fix grouped option selection and add regressions.Are there any user-facing changes?
Regular builds exclude the CI profile. Fixture installers do not establish production release qualification. No public HTTP API or persisted format changes.
How was this change tested?
Validation covers
make check, fixture regressions, core Rust tests in a standalone harness, four real SQLite Server modes, and a Chromium DOM reproduction. Full Windows Tauri installation acceptance still requires CI confirmation.AI usage statement
OpenAI Codex (GPT-6) assisted implementation, tests, and review. Maintainer review remains required.