Repository navigation
fix(dify): decouple generated contract from whole OpenAPI hash - #1908
Merged
Merged
Conversation
Refs #1904. Preserve complete artifact drift checks and cover unrelated OpenAPI changes and consumed schema changes.
PsiACE
marked this pull request as ready for review
October 9, 2026 09:56
yihong0618
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1904.
Rationale for this change
An unused whole-file hash causes unrelated OpenAPI edits to change Dify artifacts and create merge conflicts.
What changes are included in this PR?
Remove
openapi_sha256while retaining complete contract and tool declaration comparisons in--check. Add regressions for unchanged outputs after unrelated edits, drift after consumed schema changes, and modified generated artifacts.Are there any user-facing changes?
Tool behavior is unchanged. The generated runtime contract remains checked in.
How was this change tested?
Validation covers
make check, Dify generation checks, Ruff/ty, SDK tests, and real HTTP/SQLite tests. Actual Dify host tests were not configured; those cases were skipped.AI usage statement
OpenAI Codex (GPT-6) assisted implementation, tests, and review. Maintainer review remains required.