Repository navigation
Conversation
Lkx-JY
requested review from
Alanxtl,
AlexStocks,
PsiACE,
frostming and
zhanghuidinah
as code owners
October 17, 2026 07:22
Lkx-JY
force-pushed
the
docs/1391-approval-authority
branch
from
October 17, 2026 08:00
f2c1f69 to
0f70401
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Relates to #1391.
This PR does not automatically close the issue. Maintainers should confirm whether the documented approval contract resolves the report.
Rationale for this change
Some documentation states that a model cannot approve its own Candidate. The implemented contract requires a separate approval operation, but an Agent with review authority can call that operation.
This PR follows the documentation-alignment approach described in #1391. It clarifies the distinction between explicit approval, permission checks, independent review, and human confirmation.
Deployments that reserve approval for a person must use separate Agent and reviewer identities, keep reviewer credentials outside the Agent environment, and withhold review authority from the Agent.
Mandatory human confirmation and a prohibition on self-approval remain outside this PR. Either capability would require a separate proposal if the project chooses to support it.
What changes are included in this PR?
scope.review, and advisory MCP annotations.Are there any user-facing changes?
Documentation now explains how to separate Agent submission from reviewer approval.
Review does not inherently prove human confirmation or require a different proposer and reviewer. Existing automated approval remains available to authorized callers.
Runtime behavior, public APIs, configuration, and persisted formats are unchanged. No migration is required.
How was this change tested?
Results:
make check: passed.make docs-test: passed, including verification of 940 exported public pages and their internal links.git diff --check: passed.The new cases use temporary SQLite storage, the built-in authorization provider, a test Authentication Provider, and in-process HTTP/MCP transports. They do not validate an external identity provider or confirmation prompts in an Agent host.
AI usage statement
Prepared with OpenAI Codex. Codex edited the documentation, added the acceptance tests, and executed the listed validation commands.