Skip to content

fix(e2e): fill the Kimi Code Scope script path in installed guidance - #2090

Merged
hidb4ai merged 1 commit into
oceanbase:masterfrom
Fengzdadi:fix/e2e-kimi-scope-script-guidance
Oct 20, 2026
Merged

hidb4ai merged 1 commit into
oceanbase:masterfrom
Fengzdadi:fix/e2e-kimi-scope-script-guidance

Conversation

@Fengzdadi

Copy link
Copy Markdown
Contributor

Which issue or RFC does this PR close?

Fixes the validate (harness-check) failure that now shows up on PRs touching e2e/, for example #2035.

Rationale for this change

#2043 added a __POWERCONTEXT_SCOPE_SCRIPT_JSON__ placeholder to the Kimi Code skill guidance, and powercontext setup kimi-code now replaces it with the installed scripts/scope.mjs path. The ON arm's plugin installer from #2038 replaces only __POWERCONTEXT_SCOPE_JSON__. That leaves the raw marker in the installed SKILL.md, so test_kimi_code_on_arm_installs_the_plugin_as_setup_does fails. The two PRs merged 14 minutes apart, and each one passed CI against a base that did not include the other.

What changes are included in this PR?

  • harbor_kimi_code.CONFIGURE_PLUGIN also replaces __POWERCONTEXT_SCOPE_SCRIPT_JSON__ with the JSON-encoded path of scripts/scope.mjs in the installed plugin, the same way setup does.
  • The parity test normalizes each Kimi home's own path in non-JSON plugin files, because the guidance now embeds a path from inside the test's temporary directories.

Are there any user-facing changes?

No. This only changes the e2e harness and its test.

How was this change tested?

  • uv run --project e2e/bub python -m pytest e2e/bub/tests (271 passed)
  • uv run ruff check e2e/bub and uv run ruff format --check e2e/bub

AI usage statement

Claude Code (Claude Opus 5.5) found the cause in the CI log and drafted the fix and this description. I reviewed both.

oceanbase#2043 added a __POWERCONTEXT_SCOPE_SCRIPT_JSON__ placeholder to the Kimi
Code skill that setup replaces with the installed scope.mjs path. The ON
arm's installer, added in oceanbase#2038, only filled the Scope placeholder, so its
guidance kept the raw marker and no longer matched setup.
Copilot AI balanced review requested due to automatic review settings October 19, 2026 22:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@hireview001 hireview001 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidb4ai hidb4ai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidb4ai
hidb4ai merged commit a8383b4 into oceanbase:master Oct 20, 2026
32 checks passed
@hidb4ai hidb4ai added the 1.4.1 v1.4.1 release tracking label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.4.1 v1.4.1 release tracking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants