Repository navigation
fix(zcode): abort unknown boundary flush after request arrival - #2094
Merged
hidb4ai merged 1 commit intoOct 20, 2026
Merged
Conversation
|
|
luochen211
marked this pull request as ready for review
October 20, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Fixes #2080.
Rationale for this change
The
unknowncase inpending preserves concurrent receipts and pauses unknown writesrelied on an 800 msAbortSignal.timeoutracing a 1200 ms fixture delay. The timeout also covered filesystem work before HTTP dispatch, so on a slow runner the signal could fire before the request was sent, andfailedwas then the correct result.What changes are included in this PR?
unknowncase now holds the fixture response and aborts the flush from the server's request-arrival hook, so cancellation always happens after dispatch.unknownfor uncertain delivery;failedfor unsent requests is unchanged.Are there any user-facing changes?
No.
How was this change tested?
node --test integrations/zcode/plugins/powercontext/tests/*.test.mjs: 22 passed (withTMPDIR=/private/tmpon macOS; the unrelated scope test otherwise fails on the/var->/private/varsymlink, same as on master).node --test integrations/zcode/plugins/powercontext/tests/boundary.test.mjs5 times in a row: all passed.AI usage statement
Claude Code was used to investigate the flaky test, draft the test change, and run the local test suite. I reviewed the change and the test results.