Repository navigation
fix: tolerate multiple scheduler activations in trace test - #2097
Merged
hidb4ai merged 1 commit intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #2071.
Rationale for this change
The scheduler activation test compares every completion log's trace ID with the first root span's trace ID. Each activation creates an independent root trace, so multiple valid activations can cause the test to fail.
What changes are included in this PR?
Are there any user-facing changes?
No. This change only updates a test; runtime behavior and public APIs are unchanged.
How was this change tested?
Validated locally with Python 3.11.16:
Confirmed that waiting for two activations causes the original assertion to fail for both memory and experience.
Ran
test_scheduler.py: 18 passed.Ran the following related tests with four workers: 50 passed.