Repository navigation
feat(recall): add bounded atomic memory manifest - #2192
Conversation
hidb4ai
left a comment
There was a problem hiding this comment.
The tagged manifest path rejects valid input, and the Desktop and skill-validation contracts need to be synchronized. Details inline.
a36e595 to
530b99c
Compare
hidb4ai
left a comment
There was a problem hiding this comment.
One blocking upgrade regression remains at 984101b7; details inline.
hidb4ai
left a comment
There was a problem hiding this comment.
Rechecked b36f7615: the previous nonempty SQLite upgrade failure is fixed. The original reproduction now reaches v1_4_1_004 and verifies successfully.
Please address the remaining issues before merging:
- The existing OceanBase exact-kind P2 remains unchanged:
manifest()still uses plainkind == kindatruntime/atomic_memory.py:443, unlike the exact comparisons in list/search. - Current master
aedf7bebalready registersv1_4_1_004for durable owner-recovery storage, while this branch uses the same revision/resource names for descriptions.git merge-treeconfirms conflicts in the migration, schema resources, manifests and vector layout; GitHub also reportsCONFLICTING. Please integrate both storage changes into a consistent registered chain and rerun upgrades and checks on the resulting merge.
CI attribution: the reported Main jobs ran merge commit 038a8f9c (b36f7615 merged into 927bb6ee), rather than the PR head alone. I reproduced the policy failure and the owner-recovery/cross-database E2E failures on that CI base without this PR; the PR head's own policy check passes. Please refresh the compatibility review for the final integrated tree and provide passing validation with the updated commit.
hireview001
left a comment
There was a problem hiding this comment.
- CI failed: tests (3.14, unit) (failure).
- CI failed: tests (3.11, unit) (failure).
- CI failed: tests (3.13, unit) (failure).
- CI failed: tests (3.12, unit) (failure).
- CI failed: Main (failure). Failed steps: tests (3.12, unit) / Run unit tests; tests (3.13, unit) / Run unit tests; tests (3.11, unit) / Run unit tests.
PR oceanbase#2192 registers `v1_4_1_005` for the atomic memory description revision and opened six days earlier, so it keeps that number. Two open pull requests claiming one revision name would ship two different DDL sets and two different offline fingerprints under a single name, and the winner would depend on merge order. This PR moves to the next free number instead. The chain is otherwise unchanged: `down_revision` stays `v1_4_1_004`, the SQLite fingerprint is unchanged because inventory never contains the revision name, and `release/upgrade-support.json` is re-digested with `scripts/upgrade_release_gate.py::managed_digest`. When oceanbase#2192 lands first this revision will rebase onto it and point `down_revision` at its `v1_4_1_005`. Verified with `tests/test_migration_revision_names.py`, `test_full_server_migrations.py`, `test_portable_storage_migration.py`, `test_owner_recovery_migration.py`, `test_release140_server_migrations.py` and `test_server_migration_cli.py` (46 passed), plus a full `s1300`-to-head replay that reproduces every recorded fingerprint.
hireview001
left a comment
There was a problem hiding this comment.
- CI failed: cindy-package (failure).
- CI failed: Main (failure). Failed steps: cindy-package / Build and test the standalone Cindy archive.
…x/pr2192-resolve-conflicts-20261030
Which issue or RFC does this PR close?
Closes #1864
Rationale for this change
Agents currently need to retrieve memory content before deciding which entries are useful. A bounded, metadata-only manifest provides a cheaper first step, allowing agents to select entries before fetching their full content.
What changes are included in this PR?
Are there any user-facing changes?
POST /v1/recall/manifestandget_recall_manifest.How was this change tested?
make checkAI usage statement