Repository navigation
test(recall): repin prepare statement ceiling after consolidation - #2200
Merged
Merged
Conversation
The default text-recall preparation now issues 17 statements for both 8 and 40 memories, but the guard still allowed 41, so a regression up to the old budget would pass silently. Pin the measured value with one statement of slack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
No issue to close. Follow-up to #2075 and #2079.
Rationale for this change
test_prepare_context_statement_count_does_not_grow_with_memory_countguards recall against per-candidate authority reads, but its ceiling still sits at 41 from #2133. After #2079 consolidated the recall queries, the same path measures 17 statements on master (464cd152) for both 8 and 40 memories, so the guard currently permits more than twice the real cost and a 42-statement regression would pass silently.What changes are included in this PR?
_PREPARE_STATEMENT_CEILING: 41 -> 18 (measured 17 plus one statement of slack, matching the existing convention).Are there any user-facing changes?
No. Test-only change.
How was this change tested?
pytest tests/builtin/runtime/test_statistics.py -q-> 10 passed.464cd152: 17 statements for both 8 and 40 memories.