This repository was archived by the owner on Aug 22, 2023. It is now read-only.
Add isRunByDefault option to command.run()#100
Open
rizzlesauce wants to merge 2 commits intooclif:mainfrom
Open
Add isRunByDefault option to command.run()#100rizzlesauce wants to merge 2 commits intooclif:mainfrom
rizzlesauce wants to merge 2 commits intooclif:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
- Coverage 66.81% 0% -66.82%
=========================================
Files 7 2 -5
Lines 452 12 -440
Branches 127 3 -124
=========================================
- Hits 302 0 -302
+ Misses 101 12 -89
+ Partials 49 0 -49
Continue to review full report at Codecov.
|
Author
|
I need to add more to this to get to the desired signature of: Command.run({isRunByDefault: boolean}). EDIT: this is done |
983988e to
0e3b914
Compare
Contributor
|
Thanks for the PR on this @rizzlesauce! I really don't like to not use your efforts, but this particular solution was an edge case that was easier for me to write than explain. Thanks for your patience as well! See my comment oclif/oclif#277 (comment) on adding a root index command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oclif/oclif#277