This repository was archived by the owner on Aug 22, 2023. It is now read-only.
feat: Add support for Custom tsconfig.json, Resolve extended configs#225
Open
Saeris wants to merge 1 commit intooclif:mainfrom
Open
feat: Add support for Custom tsconfig.json, Resolve extended configs#225Saeris wants to merge 1 commit intooclif:mainfrom
Saeris wants to merge 1 commit intooclif:mainfrom
Conversation
This addresses both oclif/oclif#299 and oclif/oclif#488 `loadTSConfig()` in `src/ts-node.ts` was not properly resolving extended configuration files, because while `parseConfigFileTextToJson` will load and parse a given `tsconfig.json` file, it does not merge compilerOptions from configs specified in the `extends` option. This implementation is based on the solutions suggested in microsoft/TypeScript#5276 and https://stackoverflow.com/questions/53804566/how-to-get-compileroptions-from-tsconfig-json which rely on Typescript's utilities for loading and parsing `tsconfig.json` files. Specifically, by adding a call to `parseJsonConfigFileContent()`, the merged compilerOptions will be resolved as expected. Additionally, this adds support for user-defined tsconfig files through the `tsConfig` option under `oclif` key in their `package.json`.
|
Thanks for the contribution! Before we can merge this, we need @Saeris to sign the Salesforce.com Contributor License Agreement. |
Author
|
I'm not sure what is causing the tests in https://github.com/oclif/config/blob/master/test/typescript.test.ts to fail. Some guidance here would be appreciated. |
Author
|
Should also be noted that I bumped |
|
Is oclif actively maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses both oclif/oclif#299 and oclif/oclif#488
loadTSConfig()insrc/ts-node.tswas not properly resolving extended configuration files, because whileparseConfigFileTextToJsonwill load and parse a giventsconfig.jsonfile, it does not merge compilerOptions from configs specified in theextendsoption.This implementation is based on the solutions suggested in microsoft/TypeScript#5276
and https://stackoverflow.com/questions/53804566/how-to-get-compileroptions-from-tsconfig-json which rely on Typescript's utilities for loading and parsing
tsconfig.jsonfiles.Specifically, by adding a call to
parseJsonConfigFileContent(), the merged compilerOptions will be resolved as expected.Additionally, this adds support for user-defined tsconfig files through the
tsConfigoption underoclifkey in theirpackage.json.