Declare ocsigen-dune-rules as a build dependency#706
Open
balat wants to merge 2 commits into
Open
Conversation
- Convert <<a_api>>/<<a_manual>> wikidoc refs in src/os_*.{eliomi,eliom}
to native odoc references ({!Module}/{{!page-X}}).
- Add doc/intro.mld (converted from wikidoc doc/6.x/manual/intro.wiki),
doc/index.mld (landing page) and doc/dune declaring them in the
ocsigen-start package, so manual + API build together with odoc and
cross-references resolve.
Built by wodoc for ocsigen.org; ignored markers keep the source valid
for ocaml.org's stock odoc.
The build invokes the ocsigen-dune-rules code generator via (run ocsigen-dune-rules .) but never declared it as a dependency, so a clean opam install failed with "Program ocsigen-dune-rules not found".
Julow
reviewed
Jun 9, 2026
Julow
left a comment
Julow
left a comment
Contributor
There was a problem hiding this comment.
This doesn't make sense. Ocsigen-dune-rules is vendored
Member
Author
|
I probably chose the wrong base branch for the PR. It is supposed to fix an issue with recent versions where it is not vendored any more. I'll fix that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build runs the ocsigen-dune-rules generator but never declared it; a clean opam install failed with 'Program ocsigen-dune-rules not found'.