Fix cascading category bracket invalidation - #1
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Octavio Frangipani <octapf@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Editing the winner of a completed category bracket match only reset immediate dependent matches. If later rounds had already been completed, downstream matches could remain completed with stale teams/winners from the old branch, corrupting the published bracket state.
Root cause
recomputeCategoryBracketAfterWinnerChangerecomputed each match once from the pre-edit winner map. Matches fed by a reset downstream match did not see that dependency as invalidated, so their completed scores and winners could survive even though their slot was no longer known.Fix
Track invalidated matches while recomputing category slots and cascade that invalidation through winner/loser feeds. Any match whose feeder was reset now has its affected slot cleared and score/referee/completion fields removed.
Validation
tests/knockoutAdvance.test.tsfor a stale final after a changed upstream winner.npm test -- tests/knockoutAdvance.test.tsandnpm run typecheck, but this cloud image has nonpm/Node tooling on PATH.