Fix live tournament roster mutation guards - #10
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Octavio Frangipani <octapf@users.noreply.github.com>
Co-authored-by: Octavio Frangipani <octapf@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After a tournament started, several server routes still allowed roster/team mutations: creating a team, changing a team's group index, and deleting a single guest player. A concrete organizer/API flow could dissolve or reshuffle teams during live classification/category play, corrupting fixtures/brackets and player roster state.
Root cause
Recent post-start guards covered entry updates, team deletion, and bulk guest deletion, but did not cover
POST /api/teams,PATCH /api/teams/:idforgroupIndex, or thedeleteGuestPlayertournament action.Fix
isTournamentStartedis true.Validation
npm test -- --run tests/startedRosterGuards.test.tsnpm run typechecknpm test