Fix transitive category bracket resets - #22
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Octavio Frangipani <octapf@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Editing a completed upstream category knockout match could reset only its direct child while leaving deeper downstream matches (for example, the final in an 8-team bracket) completed with stale teams, scores, and winners. Bets on matches that were reset by bracket recomputation also remained settled.
Root cause
recomputeCategoryBracketAfterWinnerChangecomputed winners/losers from a single stale DB snapshot and performed one pass, so descendants still saw intermediate feeder matches as completed with their old winner.Fix
Validation
npm test -- --run tests/knockoutAdvance.test.tsnpm run typechecknpm run lint(passes with existing warnings)npm test