adding multilingual processing for Pages; mimicking process used for …#20
Open
uaqben wants to merge 2 commits into
Open
adding multilingual processing for Pages; mimicking process used for …#20uaqben wants to merge 2 commits into
uaqben wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @imathis
This is my first pull request - I hope it's ok 😅
I looked into the gem's code to see if I could solve my problem #19 "upstream".
Basically I duplicated parts of the processing I saw you were doing for
Posts, and set these to focus onPages.The result is that it solves my issue #19
I can use the super-clean markup for my navigation bar in the
_includes/header, (ie. just using the default[1]), and now compiling the site jekyll will correctly only pull/include the pages which are of the same language.If you can include and/or improve this multilingual processing for
Pagesit would be really cool. Thanks![1]
{% for page in site.pages %} {% if page.title %} ... {% endif %} {% endfor %}