Skip to content

fix: make popover charts respect history setting - #57

Merged
odfalik merged 2 commits into
mainfrom
fix/consistent-history-display
Jan 26, 2026
Merged

fix: make popover charts respect history setting#57
odfalik merged 2 commits into
mainfrom
fix/consistent-history-display

Conversation

@odfalik

@odfalik odfalik commented Jan 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removed the 30-sample limit on popover charts so both menu bar sparkline and popover display the full history as configured in settings
  • Changed network speed display from bytes/sec (MB/s) to bits/sec (Mbps) to match router/ISP conventions
  • Reset popover to default view when closed (no longer stays on settings/diagnostics)

Test plan

  • Set history duration to various values (30s, 60s, 5min)
  • Verify popover charts show the same time range as menu bar sparkline
  • Verify network speeds now display in Mbps and match router readings
  • Open settings or diagnostics, close popover, reopen - should be back to default view

🤖 Generated with Claude Code

odfalik and others added 2 commits January 25, 2026 15:58
Previously, popover charts were limited to 30 samples regardless of the
history duration setting, while the menu bar sparkline showed the full
history. This made the displays inconsistent.

Now both views show the complete history as configured in settings.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Changed network display from bytes/sec (MB/s) to bits/sec (Mbps)
  to match router/ISP conventions
- Reset popover to default view (not settings/diagnostics) when closed

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@odfalik
odfalik force-pushed the fix/consistent-history-display branch from f44fcde to 40740b6 Compare January 26, 2026 00:00
@odfalik
odfalik merged commit 5a86c45 into main Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant