Skip to content

Fix cut selection with belief and objective states#893

Merged
odow merged 3 commits into
masterfrom
od/fix-892
Apr 23, 2026
Merged

Fix cut selection with belief and objective states#893
odow merged 3 commits into
masterfrom
od/fix-892

Conversation

@odow
Copy link
Copy Markdown
Owner

@odow odow commented Apr 23, 2026

Closes #892

Quite a bad correctness bug, but a bit tricky to find in simple tests!

Cuts get deleted, but because cut.belief_y was a pointer to node.belief_state.belief, if they later get added back and the belief has changed then they get added back in the wrong place.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (3f6c839) to head (b3201e3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   96.37%   96.40%   +0.02%     
==========================================
  Files          28       28              
  Lines        4032     4035       +3     
==========================================
+ Hits         3886     3890       +4     
+ Misses        146      145       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odow odow merged commit 3f48b07 into master Apr 23, 2026
7 checks passed
@odow odow deleted the od/fix-892 branch April 23, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in partially observable

1 participant