Skip to content

Fix template builders missing placeholders Egeria added: directoryAddress, fileAddress and more (ISSUE-160) - #474

Merged
dwolfson merged 2 commits into
odpi:mainfrom
dwolfson:fix/issue-160-template-placeholders
Oct 21, 2026
Merged

dwolfson merged 2 commits into
odpi:mainfrom
dwolfson:fix/issue-160-template-placeholders

Conversation

@dwolfson

@dwolfson dwolfson commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Fixes ISSUE-160 in PYEGERIA_ISSUES.md: AutomatedCuration's template builders didn't send placeholders that Egeria's templates now use. The created elements kept literal ~{name}~ values.

Found live on 2026-10-21 against Egeria main 05a5e982. A folder made with create_folder_element_from_template had the endpoint address ~{directoryAddress}~, so Egeria's folder survey failed with BASIC-FILE-CONNECTOR-404-001.

Cause

No placeholder was renamed; Egeria added some:

  • directoryAddress and fileAddress (Egeria commit 156650efd6) are now the endpoint address in the folder and file templates. The templates still use directoryPathName / filePathName in the qualified name, so both are needed.
  • deployedImplementationType is in every folder and file placeholder list.
  • The PostgreSQL database template's description placeholder is databaseDescription, not description.

Change

Method signatures are unchanged; each builder now also sends:

Method Now also sends
create_folder_element_from_template directoryAddress (the path name), deployedImplementationType
create_csv_data_file_element_from_template, get_create_csv_data_file_element_from_template fileAddress (the file path name), deployedImplementationType
create_secrets_store_element_from_template fileAddress, deployedImplementationType
create_postgres_database_element_from_template databaseDescription

ISSUE-160 also lists mismatches this PR leaves for a decision: the Postgres secrets-store placeholders, unset optional arguments, and the Unity Catalog / Kafka extras.

Testing

  • tests/micro-tests/test_issue_160_template_placeholders.py: 5 cases. All fail on the old code and pass with the fix.
  • The full micro-test suite (1,409 tests) passes in a clean python:3.13-slim container with no Egeria.
  • Live, on Egeria main 05a5e982 with a throwaway folder: the Endpoint's networkAddress is the real path, deployedImplementationType and versionIdentifier are filled, and no ~{...}~ is left on the folder, Connection or Endpoint. All three were purged and verified gone.

🤖 Generated with Claude Code

dwolfson and others added 2 commits October 21, 2026 09:40
…w placeholders (ISSUE-160)

Egeria added the directoryAddress and fileAddress placeholders (now the
Endpoint address in the folder and file templates) and
deployedImplementationType to the folder/file placeholder lists; the
PostgreSQL database template's description placeholder is
databaseDescription. pyegeria never sent them, so created elements kept
literal ~{name}~ values. A folder's endpoint stayed ~{directoryAddress}~
and Egeria's folder survey failed with BASIC-FILE-CONNECTOR-404-001.

Folder, both CSV, secrets-store and Postgres database builders now send
the missing keys; signatures unchanged. Remaining mismatches (Postgres
secrets placeholders, unset optional placeholders, UC/Kafka extras) are
listed in ISSUE-160 for the owner.

Micro-tests: tests/micro-tests/test_issue_160_template_placeholders.py
(all fail on the old code). Full micro-test suite passes in a clean
python:3.13-slim container.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
…ow filled

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
@dwolfson
dwolfson merged commit 6f3ee8a into odpi:main Oct 21, 2026
5 checks passed
dwolfson added a commit that referenced this pull request Oct 21, 2026
Ships the ISSUE-160 template-placeholder fixes from #474 and #475:
AutomatedCuration's template builders now send directoryAddress,
fileAddress, deployedImplementationType, databaseDescription, the
Postgres secrets-store placeholders and the UC/Kafka placeholders, and
send "" for unset optional placeholders, so no created element keeps a
literal ~{name}~. db_user/db_pwd on the Postgres builders are
deprecated and ignored.

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
dwolfson added a commit that referenced this pull request Oct 28, 2026
* docs(issues): re-sort the issue trackers, open items first

PYEGERIA_ISSUES.md:
- Released fixes still marked "not yet released" now name the PR and
  release: ISSUE-111/113/129/134/136 (#446) and ISSUE-135 (#445) in
  6.2.2, ISSUE-153 (#460) 6.2.5, ISSUE-160 (#474/#475 6.2.8, #478 6.2.9),
  ISSUE-161 (#477) 6.2.9, ISSUE-162 (#482) and ISSUE-163/164 (#483)
  6.2.10. ISSUE-166 notes the pyegeria side (#498, 6.2.13).
- Moved the fixed entries (ISSUE-153, 160-166) from the open sections
  to the top of Fixed / Resolved.
- Awaiting re-test is now a real section after the open ones, holding
  ISSUE-125, 124, 117, 112, 90, 95 and 89. Its old header sat in the
  middle of the Fixed list, where everything under it except ISSUE-95
  and ISSUE-89 was already fixed.
- The At-a-glance counts and lists are rebuilt from the section
  contents (14 open pyegeria items, 7 awaiting re-test, 5 open Egeria
  Server issues), and the re-test section notes the quickstart now runs
  Egeria main abe31272.

EGERIA_OPEN_ISSUES.md: drop the fixed ISSUE-166 entry, and move
ISSUE-79 (Egeria needs information) and ISSUE-38 (pending oak2026
merge) out of Awaiting re-test, matching their 2026-10-18 status.

No entry text was removed: 166 entries before and after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>

* docs(issues): ISSUE-165 released in 6.2.11

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>

---------

Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@dwolfson
dwolfson deleted the fix/issue-160-template-placeholders branch October 30, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant