Repository navigation
Keep ISC upper-case in report headings; docs for GENERATED_EXTRA_COLUMNS; backlog item - #505
Merged
dwolfson merged 3 commits intoOct 28, 2026
Conversation
- dr_egeria_manual, CLAUDE.md, AGENTS.md: generated report spec columns come from the Create command's attributes; display-only server-returned columns (the ISC mermaid graphs, odpi#503) go in GENERATED_EXTRA_COLUMNS in gen_report_specs.py, not the compact spec. The manual also notes the -DrE-Basic/-DrE-Advanced suffix is required. - BACKLOG: a bare "...-DrE" report spec name silently falls back to the default report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
camel_to_title_case only keeps words listed in REPORT_ACRONYMS upper-case, and "ISC" isn't one of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
changed the title
REPORT section headings for the ISC graphs (odpi#503) read "Isc Data Mesh Graph": camel_to_title_case only keeps words listed in REPORT_ACRONYMS upper-case. Add "ISC". This also lets _is_mermaid_attribute's name-based fallback match the "ISC ..." entries in MERMAID_GRAPH_TITLES. Replaces the backlog entry added in the previous commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #503: docs, one backlog item, and a small heading fix.
pyegeria/core/_globals.py: add"ISC"toREPORT_ACRONYMS. REPORT section headings for the ISC graphs read "Isc Data Mesh Graph" becausecamel_to_title_caseonly keeps listed acronyms upper-case. They now read "ISC …", matching the Column names. This also lets_is_mermaid_attribute's name-based fallback match the "ISC …" entries inMERMAID_GRAPH_TITLES. Everycamel_to_title_casecaller uses the result for display only.docs/dr_egeria_manual.md,CLAUDE.md,AGENTS.md: generated report spec columns come from the Create command's attributes, which are inputs. Display-only server-returned columns, such as the five Egeria 6.3 ISC mermaid graphs, go inGENERATED_EXTRA_COLUMNSincommands/tech/gen_report_specs.py, not in the compact spec, where they would become authorable template fields. The manual also notes that generated spec names need the-DrE-Basic/-DrE-Advancedsuffix.BACKLOG.md: a new low-priority item. A bare...-DrEreport spec name (e.g.Information-Supply-Chain-DrE) silently falls back to the default "Any Metadata Element" report instead of resolving or naming the closest spec.Testing
find_information_supply_chainsREPORT output withCommon-Mermaidnow has headings "ISC Implementation Graph", "ISC Data Mesh Graph", "ISC System Fabric Graph", "ISC Data Fabric Graph" and "ISC Data Mapping Graph".🤖 Generated with Claude Code
https://claude.ai/code/session_015pdMuTg6FmqPWeapeXM54g