Preserve generated classification in watch updates - #22
Merged
Conversation
- Populate Generated summary via detector in ApplyWatchChanges - Maintain code-generated file classification during incremental updates - Add test verifying metadata persistence and filter behavior Buckley-Change-Hash: sha256:1acc7cd22c7e1e6c2564cdcb6552726f0eaf42ae5fbd76ae50b08fcf883d1451 Buckley-Change-Stats: files=2 insertions=65 deletions=0 binaries=0
odvcencio
marked this pull request as ready for review
August 24, 2026 06:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithoutGeneratedbehavior with a focused regressionBaseline evidence
On exact main
41439d48c60c7f5d5f9ea237874ec1cc536f76cc, the regression starts with one generatedapi.pb.gofile and fails afterApplyWatchChangesbecause the generated file count becomes zero.Validation
go test ./pkg/index -count=1go test -race ./pkg/index -count=1go test ./... -count=1go test -race ./... -count=1protobuf/filenamegenerated metadata after a structural update--include-generatedexposed both