fix(email): preserve reader folder for message actions#5593
Open
adabarbulescu wants to merge 1 commit into
Open
fix(email): preserve reader folder for message actions#5593adabarbulescu wants to merge 1 commit into
adabarbulescu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reader-level email actions now keep using the opened message's original folder/account instead of the currently selected
library folder, so permanent delete and related actions address the correct IMAP mailbox. Destructive reader actions also
check backend
{success:false}responses before removing the email from the UI, preventing failed deletes from lookingsuccessful.
Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. Ifyour PR is on
mainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #5569
Type of Change
Checklist
pewdiepie-archdaemon/odysseus/pulls) — this is not a duplicate.
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checksand unit tests are not enough.
How to Test
delete, and delete permanently.
was originally opened.
{success:false}response and confirmdestructive actions leave the message visible and show an error toast.
Visual / UI changes — REQUIRED if you touched anything that renders
--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values,font sizes, or spacing units.
static/index.html) orplain text.
Fira Code) for primary UI text. Don't override.one.
Screenshots / clips
N/A: no visual rendering change. This only changes which folder/account reader actions send to the existing API endpoints and how failed responses are handled.