Good faith PR - fix various issues mentioned in issues #182
Open
Liquidmasl wants to merge 20 commits intoofekashery:masterfrom
Open
Good faith PR - fix various issues mentioned in issues #182Liquidmasl wants to merge 20 commits intoofekashery:masterfrom
Liquidmasl wants to merge 20 commits intoofekashery:masterfrom
Conversation
- Rename vertical-stack-in-card.js to nested-lovelace-card.js - Add package.json with version 1.0.0 - Fix release workflow: remove build step, correct artifact filename - Update hacs.json filename - Update LICENSE with new copyright holder - Update card display name and documentationURL
The getConfigElement() patch was only forwarding type/title/cards to the hui-vertical-stack-card editor, causing horizontal, styles, grid_options, visibility, and other properties to be silently lost whenever the card was saved through the visual editor. Fix by retaining the full config and intercepting the config-changed event to merge stripped properties back before HA receives the update. Fixes ofekashery#178, ofekashery#174, ofekashery#173, ofekashery#171, ofekashery#162 from ofekashery/vertical-stack-in-card
- Update title, badges, and all URLs to new repo - Fix file references to nested-lovelace-card.js - Add fork notice with backward-compat note and switch guide - Update HACS install instructions for custom repository - Update manual install to use latest release download URL - Credit original author in acknowledgements
Add npm version lifecycle script that auto-patches the version string in nested-lovelace-card.js whenever 'npm version' is run, so the JS console log always stays in sync. Remove the now-redundant VERSION file.
…ze stacked card width and height, using grid options. added example image in the readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a good faith attempt in reviving this repo, although I am planning to keep the fork maintained.
this PR fixes issues with visibility settings, grid settings, and more being removed by the visual editor.
Also implement support for grid sizing and added horizontal toggle to the visual editor