Fix seed provider default_reasoning_effort for non-claude/codex kinds - #12
Open
amirfish1 wants to merge 1 commit into
Open
Fix seed provider default_reasoning_effort for non-claude/codex kinds#12amirfish1 wants to merge 1 commit into
amirfish1 wants to merge 1 commit into
Conversation
_new_provider_record() hardcoded default_reasoning_effort to the global
DEFAULT_REASONING_EFFORT ("medium") regardless of provider kind. Kinds
whose reasoning_effort_options exclude "medium" (e.g. agy, copilot,
qwen, amp — no options at all — or opencode: minimal/high/max) produced
a record that failed the strict round-trip canonicalization check in
_normalize_loaded_state, crashing apply_installation_profile_selection
on first install with "unsupported provider config schema: noncanonical
provider record".
Compute the value the same kind-aware way _clean_provider_record does,
so newly seeded providers always round-trip cleanly.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014ZVWhGL56jcSi2Fb3EUx2g
ofekron
added a commit
that referenced
this pull request
Aug 6, 2026
Locks the invariant amirfish1 reported in PR #12: seeding must derive default_reasoning_effort kind-aware, so kinds whose options exclude "medium" (agy, amp, copilot, qwen — no options; opencode — minimal/high/max) do not produce a noncanonical record that crashes first install with "noncanonical provider config schema". The original defect lived in _new_provider_record on main; on dev the value moved to _seed_profile_for_provider and is already kind-aware. This test covers the current shape so the regression cannot return. Reported-by: Amir Fish <amir.fish@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_new_provider_record()hardcodeddefault_reasoning_effortto the globalDEFAULT_REASONING_EFFORT("medium") for every provider kind.reasoning_effort_optionsexclude"medium"(e.g.agy,copilot,qwen,amp— no options at all — oropencode:minimal/high/max) got a seeded record that fails the strict round-trip canonicalization check in_normalize_loaded_state, crashingapply_installation_profile_selectionon first install with:default_reasoning_effortthe same kind-aware way_clean_provider_recorddoes, so newly seeded providers always round-trip cleanly.Test plan
_new_provider_record(kind)round-trips through_clean_provider_record(== canonical) for everyprovider_manifest.installable_kinds():agy,amp,claude,codex,copilot,opencode,pi,qwen— all OK.agy-selectedinstallation.jsonand confirmeddependency_plan.py apply-selectionno longer raisesnoncanonical provider recordafter the fix.🤖 Generated with Claude Code
https://claude.ai/code/session_014ZVWhGL56jcSi2Fb3EUx2g