Skip to content

test(e2e): refresh Google client-setup screenshot (Task 2 evidence) - #64

Merged
alichherawalla merged 1 commit into
mainfrom
test/google-setup-e2e
Jul 24, 2026
Merged

test(e2e): refresh Google client-setup screenshot (Task 2 evidence)#64
alichherawalla merged 1 commit into
mainfrom
test/google-setup-e2e

Conversation

@alichherawalla

Copy link
Copy Markdown
Contributor

Stacked on #63 (Task 1 e2e). Paired e2e evidence for desktop-pro Google-setup PR. Base retargets to main once #63 merges.

Screenshot

e2e/screenshots/qh-integrations-byo-google-setup.png — verified by reading the image. The rebuilt BYO Google modal shows:

  • cross-platform copy: "your device's secure store (Keychain on macOS, Credential Manager on Windows)"
  • step 3: "Configure the OAuth consent screen … set App name to Off Grid AI Desktop … Add your own Google account under Test users" (the "News flash" fix)
  • step 4: create the Desktop OAuth client — correctly reordered after the consent screen.

Content is guarded by the GoogleClientSetup integration test in desktop-pro (order + naming + copy); this is the visual evidence in the actual built app.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • e2e/screenshots/qh-integrations-byo-google-setup.png is excluded by !**/*.png
  • e2e/screenshots/qh-integrations-overview.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3a22a8f-2fc4-43e8-9326-263a871a4376

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/google-setup-e2e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Regenerated after the BYO Google setup copy fix. The modal now shows: cross-platform
credential-store copy (Keychain on macOS / Credential Manager on Windows), the new
'Configure the OAuth consent screen' step naming the app 'Off Grid AI Desktop' (the
'News flash' fix), and the create-client step reordered after it. Content is guarded
by the GoogleClientSetup integration test in desktop-pro; this is the visual evidence.
@alichherawalla
alichherawalla force-pushed the test/google-setup-e2e branch from cfb5903 to e635f8b Compare July 24, 2026 08:43
@alichherawalla
alichherawalla changed the base branch from test/capture-optin-e2e to main July 24, 2026 08:43
@sonarqubecloud

Copy link
Copy Markdown

@alichherawalla
alichherawalla merged commit ef2dfcb into main Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant