Repository navigation
refactor(streaming): write-only column widths reuse serializeCols - #316
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
The write-only writer had its own copy of the <col> coalescing loop added in Build ColumnDimension entries and call the modelled writer's serializeCols so there is one coalescing implementation. Reword the #315 changeset to tell users that a reloaded file holds one columnDimensions entry per range. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNFNHrh8yhz9PQ3bWTPBHo
baseballyama
force-pushed
the
refactor/write-only-reuse-serialize-cols
branch
from
November 8, 2026 23:09
a562edc to
76550b5
Compare
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #315. The write-only writer now emits
<cols>through the sameserializeColsthe modelled writer uses, instead of a second copy of the coalescing loop. Output is byte-identical.Motivation
#315 added range coalescing twice: once in
serializeColsand once inline insrc/streaming/write-only.ts, where a-1sentinel width was needed to keep column 1 at width 0 from joining an empty run. One implementation removes that sentinel and the risk of the two drifting apart.Changes
<cols>output goes throughserializeCols(no output change).Testing
pnpm typecheck && pnpm lint && pnpm knip && pnpm test && pnpm build && pnpm sizepass locally.Breaking changes
None
Checklist
pnpm changesetand committedthe result.
marked accordingly.
comments.
PR represents real work that warrants a maintainer's review, and I am
willing to defend each line in review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MNFNHrh8yhz9PQ3bWTPBHo