docs(brand): describe the map as a themed surface on dash's system - #21
Merged
Merged
Conversation
The guide is a description to build against, so it is wrong the moment the surface moves. map.retina.fm has been restyled on dash.retina.fm's design system in offworldlabs/retina-server#343, #345, #346 and #347, and the guide still described the surface those PRs replaced: dark-only, no custom properties, no focus treatment, no reduced-motion guard, and a teal/cyan truth colour that no longer exists. The substantive changes on the map, and so here: - It themes. Dark stays the default and is unchanged; light is opt-in and takes dash's values. The base selector carries dark and the attribute carries light, so the default cannot flash the other theme before first paint, and that is the part worth copying rather than the values. - It has a full custom-property layer under dash's names, which makes the two consoles the only pair in the estate that share a vocabulary. §10's naming drift and shared-control bullets narrow to dash accordingly. - The data palette was rechosen by measurement, against a contrast floor and a CIEDE2000 separation between marks. Truth now wears no hue in either theme, which the old teal/cyan description in §3, §8 and tokens.css contradicted outright. - Focus and reduced motion are now handled on the map, so the blanket "none of the surfaces" claims in §5 and §10 are narrowed to the surfaces they still describe. owl's /learn page already carried a reduced-motion guard, so that claim was too broad before this change as well. §6's map entries went stale along with the rest: the gradient header, the two ad-hoc search boxes, the near-invisible empty state, the backdrop-blurred panels and the unstyled Leaflet controls are all now one thing rather than several. Recorded as they stand, not as a before-and-after. tokens.css gains --accent-tint and a .map[data-theme="light"] block mirroring the live selector, and drops --data-adsb, which no longer names anything: the ground-truth dot and truth are one colour now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The map's three geometry tokens were declared only inside its light-theme block, so the default theme rendered none of them and 8px/4px was the intent rather than the result. That is fixed in the map stack, so the scale can be stated: the map takes dash's, 8 / 4 / 12, rather than the 6 / 3 / 10 it had before the restyle. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The preview annotated the map with "Two search boxes, one job", a defect the map stack removed by giving the surface one form-control rule in its token layer, and led with "the dark operational picture" when dark is now the default rather than the whole surface. Rather than add a second map section for the light theme, which would be dash's values rendered twice, the two console tags now say which mode each one is. The guide already records that the map's light theme takes dash's values wholesale, so the preview points at the pairing instead of restating it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
map.retina.fm has been restyled on dash.retina.fm's design system, and the brand guide still described the surface that replaced. This brings
docs/brand/brand-guide.mdanddocs/brand/tokens.cssback in step with it.Land this after the retina-server stack
The map's restyle is a four-PR stack, open and unmerged at the time of writing:
feat/map-1-palette, the palette modulefeat/map-2-chrome, the chrome on dash's systemfeat/map-3-contrast, the measured data coloursfeat/map-4-theme, the light themeEverything here is written against the tip of that stack. It should not merge before the stack does, or the guide will describe a surface that is not yet live. If the stack changes shape in review, this needs re-reading against what actually lands.
What changed in the guide
The map is no longer dark-only, no longer without custom properties, and no longer without focus or reduced-motion handling, so every blanket claim resting on those has been narrowed to the surfaces it still describes rather than rewritten as a before-and-after.
Tint (hover)row for--accent-tint, and a corrected border value (.12to.14, drifted when the hardcoded hex was consolidated into tokens).prefers-reduced-motionand no-:focus-visiblegaps, and the shared-control and token-drift bullets narrow to dash. The map and dash are now the only pair in the estate sharing a vocabulary.tokens.cssgains--accent-tintand a.map[data-theme=\"light\"]block. The attribute variant mirrors the live selector exactly and stays keyed on.map, so it fits the one-class-per-surface structure rather than fighting it.--data-adsbis dropped: the ground-truth dot and truth are one colour now, and the pair is replaced by--data-truth/--data-truth-dark.Two things worth flagging
preview.htmlcarried two captions this PR deletes from the guide. It annotated the map with "Two search boxes, one job", a defect the map stack fixed by giving the surface one form-control rule in its token layer, and led with "the dark operational picture" when dark is now the default rather than the whole surface. Both are rewritten.No light-theme section was added. It would be dash's values rendered a second time, since the map's light theme takes them wholesale. The two console tags now say which mode each one is, and the guide carries the pairing in full.
§5's radius numbers are now recorded. The map's radius scale is dash's: 8px default, 4px small, 12px large. It reached the guide late because the three geometry tokens were briefly declared only inside the light-theme block, so the default theme rendered none of them; that is fixed on
feat/map-4-themeand verified in the built bundle.Conflict risk
Low, now. The
worktree-docs+owl-os-brand-surfacework merged as #20 before this branch was cut, so this is based on amainthat already contains the owl-os column and the expanded §6. It was that expansion that put most of the stale map claims in §6 here in the first place.🤖 Generated with Claude Code