Advertise dead-code-v1.1 as the current pin - #5
Merged
Merged
Conversation
Bumped before tagging, so the README shipped inside the v1.1 tag names v1.1 rather than its predecessor. Tagging first and correcting after is the loop that produced three tags for v1.0. v1.1 adds the cd guard: a target that cannot be entered now exits 2 (bad usage) with a named message, instead of exiting 1 via set -e and colliding with "dead code found". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ZcazeseXVpu8XrYA2tE1V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for tagging
dead-code-v1.1, which carries thecdguard merged in #4.Bumping the README before tagging so the README shipped inside v1.1 names v1.1. Tagging first and correcting afterwards is the self-reference loop that produced three tags for v1.0 — see #2 and #3.
What v1.1 adds over v1.0
One line in
check-dead-code.sh:A bare
cdfails underset -ewith exit 1 — the same code the gate uses for "dead code found". So a typo'dargs: [backedn]surfaced in CI as a "Dead code" step failing with exit 1, indistinguishable from a real finding. Now exits 2, the gate's existing "bad usage" code, with a script-branded message.Only Tower-Finder passes a positional target (
args: [backend]), so it is the only consumer that can hit this. The other five stay on v1.0 until they have a reason to move.🤖 Generated with Claude Code
https://claude.ai/code/session_013ZcazeseXVpu8XrYA2tE1V