Skip to content

chore(scripts): delete retnode_poller.py - #344

Merged
Babissimo merged 1 commit into
mainfrom
chore/drop-retnode-poller
Sep 9, 2026
Merged

Babissimo merged 1 commit into
mainfrom
chore/drop-retnode-poller

Conversation

@Babissimo

Copy link
Copy Markdown
Contributor

backend/scripts/retnode_poller.py polled a node's blah2 HTTP API and fed the frames into the tracker over TCP :3012, doing by hand what services/blah2_bridge.py did from a config file. Its own docstring called it "an interim approach until nodes connect directly via mTLS". Nodes now connect over the v1 HTTP API, and the bridge it mirrored went in #340.

Ticket: 86cb7v7hd

Nothing imports it and nothing invokes it: no crontab entry, no systemd unit, no compose service, no deploy script. It was deliberately left out of #340 because it is manual and tracked separately.

The scripts/* entries in backend/pyproject.toml (coverage omit, ruff per-file-ignores) stay as they are — they are globs covering the other scripts, which remain.

pre-commit run --all-files passes all five hooks.

🤖 Generated with Claude Code

A standalone CLI that polled a node's blah2 HTTP API and fed the frames into
the tracker over TCP :3012, doing by hand what services/blah2_bridge.py did
from a config file. Its own docstring called it "an interim approach until
nodes connect directly via mTLS"; nodes now connect over the v1 HTTP API, and
the bridge it mirrored was removed in #340.

Nothing imports it and nothing invokes it: no crontab entry, no systemd unit,
no compose service, no deploy script. It was left out of #340 because it is
manual and was tracked separately.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown

Claude finished @Babissimo's task in 1m 11s —— View job


Code Review: PR #344chore(scripts): delete retnode_poller.py

  • Gather context (PR body, diff, CLAUDE.md)
  • Run code review on the deletion
  • Post findings

Result: No issues found.

This is a clean, self-contained deletion of backend/scripts/retnode_poller.py (524 lines removed, nothing else touched):

  • No remaining references — nothing imports it, no crontab/systemd/compose/deploy entry invokes it.
  • backend/scripts/* globs in backend/pyproject.toml (coverage omit, ruff per-file-ignores) correctly remain untouched, since they cover the other scripts that still exist.
  • Not part of the generated node API contract surface (contracts/nodes-v1.openapi.yaml per CLAUDE.md) — it never touched /v1/nodes routes or backend/services/node_config.py, so no contract regen is needed.
  • One dated design-note doc still mentions the script by name, but that's a historical record, not living documentation — not worth flagging as a defect.

No functional, security, or maintainability concerns. Good to merge as-is.

@Babissimo
Babissimo merged commit 68a1565 into main Sep 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant