chore(scripts): delete retnode_poller.py - #344
Merged
Merged
Conversation
A standalone CLI that polled a node's blah2 HTTP API and fed the frames into the tracker over TCP :3012, doing by hand what services/blah2_bridge.py did from a config file. Its own docstring called it "an interim approach until nodes connect directly via mTLS"; nodes now connect over the v1 HTTP API, and the bridge it mirrored was removed in #340. Nothing imports it and nothing invokes it: no crontab entry, no systemd unit, no compose service, no deploy script. It was left out of #340 because it is manual and was tracked separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Claude finished @Babissimo's task in 1m 11s —— View job Code Review: PR #344 —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend/scripts/retnode_poller.pypolled a node's blah2 HTTP API and fed the frames into the tracker over TCP:3012, doing by hand whatservices/blah2_bridge.pydid from a config file. Its own docstring called it "an interim approach until nodes connect directly via mTLS". Nodes now connect over the v1 HTTP API, and the bridge it mirrored went in #340.Ticket: 86cb7v7hd
Nothing imports it and nothing invokes it: no crontab entry, no systemd unit, no compose service, no deploy script. It was deliberately left out of #340 because it is manual and tracked separately.
The
scripts/*entries inbackend/pyproject.toml(coverage omit, ruff per-file-ignores) stay as they are — they are globs covering the other scripts, which remain.pre-commit run --all-filespasses all five hooks.🤖 Generated with Claude Code