feat(#709): validate plugin config with manifest zod schema#768
Open
rbalogic wants to merge 2 commits into
Open
feat(#709): validate plugin config with manifest zod schema#768rbalogic wants to merge 2 commits into
rbalogic wants to merge 2 commits into
Conversation
Author
|
Hi @rithviknishad 👋 Just bumping this whenever you get a chance to take a look. No rush, but let me know if you need any changes or if there's anything I can clarify! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #709
configSchemasupport to the shared plugin manifest types so plugins can declare a Zod schema for their config.plugins.<id>.configduring plugin loading in the runner, beforesetup(),scrape(), oraggregate()are called.ctx.config, so plugins receive validated and transformed config values instead of raw YAML input.configSchema, including the requiredzoddependency.Merge Checklist