Reduce jp.Parse allocations#222
Open
trevorprater wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces allocations in
jp.Parseby avoiding temporary token buffers while scanning dot and recursive-descent child fragments.The parser previously built a temporary
[]bytewith repeatedappendcalls, then converted it toChild. This patch records the token start offset, advancesp.posuntil the fragment boundary, and converts the original input slice directly toChild. It also keeps the parser value on the stack inMustParseand preallocates the expression slice with a small capacity for the common short JSONPath case.Validation:
I also ran a temporary differential oracle against the previous parser over 10,058 inputs covering fixed examples from the parser tests, bracket notation, quoted children, unions, slices, filters, invalid syntax, Unicode, escaped strings, and deterministic randomized expressions/byte strings. The candidate output matched the previous parser exactly for
String(),BracketString(), and error text.Benchmark command:
benchstat:I found the candidate while experimenting with Sleepy, then reduced the generated patch to the smaller token-scanning change above and validated it manually.
Sleepy proof page - https://sleepy.run/proof