Add proper error handling for network and process issues#23
Open
ohtaman wants to merge 2 commits into
Open
Conversation
- Add custom exception hierarchy for better error handling - Implement retry mechanisms for network connectivity and port binding - Add graceful process termination with fallback force kill - Add detailed logging and error messages - Improve documentation with clear error scenarios Fixes #18
- Fix process termination to use single join call - Fix wait_for_server timeout handling - Fix test by properly mocking time.time()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR implements comprehensive error handling improvements to address the issues outlined in #18:
Network Connectivity
Port Binding
Process Management
General Improvements
Testing
The changes have been tested for:
Fixes #18