Improve test coverage#24
Open
ohtaman wants to merge 3 commits into
Open
Conversation
- Add custom exception hierarchy for better error handling - Implement retry mechanisms for network connectivity and port binding - Add graceful process termination with fallback force kill - Add detailed logging and error messages - Improve documentation with clear error scenarios Fixes #18
- Fix process termination to use single join call - Fix wait_for_server timeout handling - Fix test by properly mocking time.time()
- Add test cases for port binding error and retry mechanism - Add test for process error handling in run_streamlit - Add test for network error and retry in wait_for_server - Add comprehensive error handling tests for start_desktop_app - Increase core.py coverage from 80% to 98% - Increase overall coverage from 81% to 89% Resolves #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added comprehensive test coverage for core functionality:
Coverage Improvements
Test Additions
Added 8 new test cases:
Resolves #19