Repository navigation
[feat] Favorites own ⌘1–9; explain them on the empty tab - #720
Merged
Merged
Conversation
Every space got a digit, favorites first, so a space never pinned could hold one and the numbers matched nothing on screen. Now only favorites are numbered, and a favorite's card shows its chord on hover or focus. The native menu becomes Go to Favorite.
The empty tab only said how to add a favorite, never why. It now shows the docs card style with what favorites give you (⌘1–9 from anywhere), how to add one from the More menu or ⌘K, and a button to the full shortcut list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every space got a ⌘1–9 digit, favorites first, so a space never pinned could hold a number and the numbering matched nothing on screen. The empty Favorites tab said how to add one but never why.
aria-keyshortcutson the card).Mockup:
.claude/mockups/favorites-empty-state.html.Tests: typecheck, lint,
test:unit3687/3687; FE s21 6/6, s13 3/3, s116 6/6.Behavior change: someone with no favorites loses the digit shortcuts they had; the empty-tab card says how to get them.
Local look owed: the hover chord, and whether Escape closes the shortcut list opened from the new button (s21 closes it with its Close button: in background mode Escape didn't).