Repository navigation
[feat] Say what an organization sees before connecting - #723
Merged
Merged
Conversation
The connect dialog now states what the organization learns from this computer (name, version, OS, applied settings, backup health) and what it never sees, with a link to the managed section of the privacy policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The managed-connect dialog now tells the person what the organization will see (computer name, Mirall version and OS, which of its settings apply, whether backups work) and what it never sees (files, spaces, who they share with). It also links to
mirall.app/privacy#managed. Copy is in all five locales.Tests:
test:fe s186passes all 5 steps and asserts the disclosure text and the privacy link. The harness flagged afterwards that the deep link left the window focused. Typecheck and lint are clean.