Repository navigation
[feat] Close backup setup before the first backup runs - #724
Merged
Merged
Conversation
A backup that ended after the organization's folder went recorded its repository through the person's own settings, so leaving during a first backup kept backing up to the organization's share. A run's outcome is now recorded only while its folder is still in force.
Setup waited for the whole first backup, so the dialog sat blocked for seconds with no sign of progress. It now closes once the key is written and checked; the first backup runs in the background and Settings shows it running. The button says it is working meanwhile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting up a backup waited for the whole first backup, so the dialog sat blocked for seconds with no sign of progress. Setup now returns once the key is written into the folder and opened back with the passphrase; the first backup runs in the background and Settings → Backup shows it running. While the key step runs, the button reads "Setting up your backup…".
Running the first backup in the background exposed a race: a run that ended after leaving an organization recorded the organization's folder as the person's own. A run's outcome is now recorded only while its folder is still in force (own commit).
Tests
backup-protect+managed-backup19/19; newREGRESSION (FIX-5: left mid-run)