Skip to content

Allow OK_AUTH_REDIRECT_HOST env var #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cycomachead wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow OK_AUTH_REDIRECT_HOST env var #478

cycomachead wants to merge 2 commits into from

Conversation

@cycomachead
Copy link
Contributor

@cycomachead cycomachead commented Sep 15, 2023

This would allow us to potentially use an environment like GitHub codespaces and make it easy for web auth to work still.

alexkassil
alexkassil approved these changes Sep 19, 2023
View reviewed changes
Copy link

@alexkassil alexkassil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

edit: seems like I don't have permissions to accept :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexkassil alexkassil alexkassil approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cycomachead @alexkassil