Increasing responsiveness#12
Open
aeph6Ee0 wants to merge 2 commits into
Open
Conversation
Owner
|
Thank you for the pull request. I'm pretty busy at the moment but I will take a look at it when I have the time. |
Owner
|
Regarding your first commit: I'm not so happy with using queues for that. I would rather use condition objects or event objects for this. What do you think about this? |
Author
|
I agree with you that for the current implementation, a condition or event object would be sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the responsiveness in two ways:
Skipping and Quitting
Currently if 'n' or 'q' command is submitted, it takes up to 30 seconds for the program to respond.
This issue is resolved by introducing a signaling mechanism (queue) to wake up the thread on those events, such that the thread can immediately respond to those events.
Quitting via Ctrl-c
Currently the program hangs when trying to kill it with Ctrl-c.
This issue is resolved by handling the KeyboardInterrupt exception and cleanly shutting down the program immediately.