fix(GroupProfile): restore custom group-profile attribute extensibility#500
Open
eleonoratennyson wants to merge 1 commit into
Open
fix(GroupProfile): restore custom group-profile attribute extensibility#500eleonoratennyson wants to merge 1 commit into
eleonoratennyson wants to merge 1 commit into
Conversation
eleonoratennyson
force-pushed
the
eqt/sync-org-catalog-to-okta
branch
from
0d27c11 to
5736b0d
Compare
GroupProfile lost its extensibility after 6.6.0 (okta#365): because it is not marked x-okta-extensible, ObjectSerializer strips custom group-profile attributes (those added via the Schemas API, e.g. an org-chart id) on both serialize and deserialize, so they never reach Okta on writes and are dropped on reads. Add GroupProfile to the force-extensible list in scripts/fixSpec.cjs — matching UserProfile and OktaUserGroupProfile, which remain extensible — and regenerate. This restores the typed index signature and `static readonly isExtensible = true` so custom attributes round-trip again. Refs okta#238, okta/okta-sdk-java#1642.
eleonoratennyson
force-pushed
the
eqt/sync-org-catalog-to-okta
branch
from
5736b0d to
f58dd81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
GroupProfileis not markedx-okta-extensible, soObjectSerializerstripscustom group-profile attributes — those added via the Schemas API —
on both serialize and deserialize. Custom attributes therefore never reach Okta
on writes and are dropped on reads. This worked through 6.6.0 (#365) and
regressed afterwards.
UserProfileandOktaUserGroupProfileremain extensible;GroupProfilesupports schema extensions the same way and should be too.Issue Number: #238
What is the new behavior?
GroupProfileis added to the force-extensible list inscripts/fixSpec.cjs(alongside
UserProfile) and the SDK regenerated. This restores, onGroupProfile, theCustomAttributeValueimport, the typed index signature, andstatic readonly isExtensible = true, so custom attributes round-trip throughObjectSerializeragain.Does this PR introduce a breaking change?
Other information
src/generated/models/GroupProfile.js,src/types/generated/models/GroupProfile.d.ts) are included, per CONTRIBUTING.test/unit/group-profile-serialization.tscovering the custom-attributeround-trip (serialize + deserialize).